Implement safety-critical command handling#559
Open
GitWorkingTime wants to merge 7 commits intomainfrom
Open
Conversation
Adityya-K
reviewed
Sep 24, 2025
Contributor
Adityya-K
left a comment
There was a problem hiding this comment.
This is a really well done first commit! Just make sure to fix the CI/CD tests before you request a review since we usually want those passing before we merge anything into our main branch. I have only skimmed the PR right now but I will give it a closer look and update the instructions for what you need to do with these two commands!
Author
|
All checks have passed, now just waiting for further instructions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #502
Explain the purpose of the PR here if it doesn't match the linked issue. Be sure to add a comment in the linked issue explaining the changes.
New Changes
Explain new changes below in short bullet points.
CMD_ARMskeleton to the codebaseCMD_EXECUTEskeleton to the codebaseCMD_ARMandCMD_EXECUTETesting
Explain tests that you ran to verify code functionality.
Outstanding Changes
If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.